Configure standby callback to polling
#247
Merged
+61
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The callback will monitor the connection status and when connection is lost, it will put the poll in standby mode. * This ensures that on JupyterHub deployments, the terminated servers will not make any API requests to hub which can pollute the logs Signed-off-by: Mahendra Paipuri <[email protected]>
* By removing `interval`, the function returns immediately without blocking Signed-off-by: Mahendra Paipuri <[email protected]>
* Remove Python 3.8 and add 3.12, 3.13 in classifiers. Inline with JupyterLab Signed-off-by: Mahendra Paipuri <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Mahendra Paipuri <[email protected]>
krassowski
approved these changes
Aug 19, 2025
Address PR comments Co-authored-by: Michał Krassowski <[email protected]>
|
Oh, it looks like this one fell through the cracks. Thanks @mahendrapaipuri for the PR and @krassowski for the review! |
|
I will release this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standbycallback will put poll in standby mode when connection to the server is lost. Useful in JupyterHub deployments. See discourse thread.Closes #246, #245
@jtpio Can you please take a look at it when you get some time? Cheers!